New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added repository search ordered by stars or forks. Forks column in admin repo list. #3969

Merged
merged 3 commits into from May 24, 2018

Conversation

6 participants
@axifive
Copy link
Member

axifive commented May 15, 2018

Hello. This PR adds new sort options to search repositories. Also, I added Forks column to admin repository list.

Explore repos search:
Most stars
screenshot 2018-05-15 17 25 29
Most forks
screenshot 2018-05-15 17 25 38

Profile repos search:
Most stars
screenshot 2018-05-15 17 25 50
Fewest forks
screenshot 2018-05-15 17 25 59

Admin repos search:
screenshot 2018-05-15 17 24 44
screenshot 2018-05-15 17 25 05

Added repository search order by stars or forks.
Added Forks column to admin repository list.

Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #3969 into master will decrease coverage by <.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3969      +/-   ##
==========================================
- Coverage   20.05%   20.04%   -0.01%     
==========================================
  Files         153      153              
  Lines       30347    30355       +8     
==========================================
  Hits         6086     6086              
- Misses      23348    23356       +8     
  Partials      913      913
Impacted Files Coverage Δ
models/repo_list.go 42.95% <ø> (ø) ⬆️
routers/user/profile.go 0% <0%> (ø) ⬆️
models/user.go 23.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2a938...e1da9d7. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label May 15, 2018

@@ -12,8 +12,6 @@
<a class="{{if eq .SortType "reversealphabetically"}}active{{end}} item" href="{{$.Link}}?sort=reversealphabetically&q={{$.Keyword}}">{{.i18n.Tr "repo.issues.label.filter_sort.reverse_alphabetically"}}</a>
<a class="{{if eq .SortType "recentupdate"}}active{{end}} item" href="{{$.Link}}?sort=recentupdate&q={{$.Keyword}}">{{.i18n.Tr "repo.issues.filter_sort.recentupdate"}}</a>
<a class="{{if eq .SortType "leastupdate"}}active{{end}} item" href="{{$.Link}}?sort=leastupdate&q={{$.Keyword}}">{{.i18n.Tr "repo.issues.filter_sort.leastupdate"}}</a>
<a class="{{if eq .SortType "size"}}active{{end}} item" href="{{$.Link}}?sort=size&q={{$.Keyword}}">{{.i18n.Tr "repo.issues.label.filter_sort.by_size"}}</a>
<a class="{{if eq .SortType "reversesize"}}active{{end}} item" href="{{$.Link}}?sort=reversesize&q={{$.Keyword}}">{{.i18n.Tr "repo.issues.label.filter_sort.reverse_by_size"}}</a>

This comment has been minimized.

@techknowlogick

techknowlogick May 15, 2018

Member

Why remove sort by size?

This comment has been minimized.

@axifive

axifive May 15, 2018

Member

I moved it to /admin/repo/search.tmpl, because size only avalible for repository, but was shown for users and orgs list

This comment has been minimized.

@techknowlogick

techknowlogick May 15, 2018

Member

That's reasonable. Thanks for quick response.

@lafriks lafriks added this to the 1.5.0 milestone May 15, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels May 22, 2018

@@ -100,12 +100,12 @@
</div>
{{else if eq .TabName "stars"}}
<div class="stars">
{{template "explore/search" .}}
{{template "explore/search_repo" .}}

This comment has been minimized.

@lunny

lunny May 23, 2018

Member

why not rename it repo_search since there was a repo_list?

This comment has been minimized.

@axifive

axifive May 23, 2018

Member

ok. I renamed it

Renamed search repo template
Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
@lunny

lunny approved these changes May 24, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels May 24, 2018

@lunny lunny merged commit b908ac9 into go-gitea:master May 24, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@axifive axifive deleted the axifive:search-repo-by-starts-forks branch May 29, 2018

@lafriks lafriks added the changelog label Jun 29, 2018

aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018

Merge tag 'v1.5.0-rc1' into wild/v1.5
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment