Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete reactions added to issues and comments when deleting repository #4232

Merged
merged 3 commits into from Jun 12, 2018

Conversation

7 participants
@lafriks
Copy link
Member

lafriks commented Jun 12, 2018

As title

@lafriks lafriks added the kind/bug label Jun 12, 2018

@lafriks lafriks added this to the 1.5.0 milestone Jun 12, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #4232 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4232      +/-   ##
==========================================
+ Coverage   19.95%   19.96%   +<.01%     
==========================================
  Files         153      153              
  Lines       30518    30521       +3     
==========================================
+ Hits         6091     6094       +3     
- Misses      23512    23513       +1     
+ Partials      915      914       -1
Impacted Files Coverage Δ
models/repo.go 17.82% <0%> (-0.04%) ⬇️
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406031d...752b66e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Jun 12, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jun 12, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jun 12, 2018

@sapk

sapk approved these changes Jun 12, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jun 12, 2018

jonasfranz and others added some commits Jun 12, 2018

@techknowlogick techknowlogick merged commit 2b8c0bb into go-gitea:master Jun 12, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Jun 12, 2018

@lafriks does this need a backport?

@lafriks lafriks deleted the lafriks:fix/delete_repo_reactions branch Jun 12, 2018

@lafriks

This comment has been minimized.

Copy link
Member Author

lafriks commented Jun 12, 2018

I can create one probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.