Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook type conflation. #4285

Merged
merged 2 commits into from Jun 21, 2018

Conversation

6 participants
@aunger
Copy link
Contributor

aunger commented Jun 20, 2018

  1. Fix typo that caused Gogs hooks to be created as Gitea hooks.
  2. Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one).
Fix webhook type conflation.
- Fix typo that caused Gogs hooks to be created as Gitea hooks.
- Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one).

Signed-off-by: Russell Aunger <rba@live.com>
@aunger

This comment has been minimized.

Copy link
Contributor Author

aunger commented Jun 20, 2018

I think the drone test failed during Docker setup, unrelated to this change. Can someone rerun it?

@bkcsoft bkcsoft added the lgtm/need 2 label Jun 20, 2018

@daviian

This comment has been minimized.

Copy link
Member

daviian commented Jun 20, 2018

Done

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 20, 2018

Codecov Report

Merging #4285 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4285      +/-   ##
==========================================
+ Coverage      20%   20.01%   +<.01%     
==========================================
  Files         153      153              
  Lines       30584    30584              
==========================================
+ Hits         6119     6122       +3     
+ Misses      23537    23535       -2     
+ Partials      928      927       -1
Impacted Files Coverage Δ
routers/repo/webhook.go 0% <0%> (ø) ⬆️
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac110d1...1affced. Read the comment docs.

@lunny lunny added the kind/bug label Jun 21, 2018

@lunny lunny added this to the 1.5.0 milestone Jun 21, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jun 21, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jun 21, 2018

@lunny lunny added the backport/v1.4 label Jun 21, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jun 21, 2018

@daviian daviian merged commit 9ae7664 into go-gitea:master Jun 21, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@daviian

This comment has been minimized.

Copy link
Member

daviian commented Jun 21, 2018

@aunger Please create a backport PR (cherry-pick commit from master) to release/v1.4 branch

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jun 21, 2018

@aunger please send a backport to release/v1.4

aunger added a commit to aunger/gitea that referenced this pull request Jun 21, 2018

Fix webhook type conflation. (go-gitea#4285)
- Fix typo that caused Gogs hooks to be created as Gitea hooks.
- Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one).

Signed-off-by: Russell Aunger <rba@live.com>

aunger added a commit to aunger/gitea that referenced this pull request Jun 21, 2018

Fix webhook type conflation. (go-gitea#4285)
- Fix typo that caused Gogs hooks to be created as Gitea hooks.
- Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one).

Signed-off-by: Russell Aunger <rba@live.com>

daviian added a commit that referenced this pull request Jun 21, 2018

Fix webhook type conflation. (#4285) (#4289)
- Fix typo that caused Gogs hooks to be created as Gitea hooks.
- Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one).

Signed-off-by: Russell Aunger <rba@live.com>

HoffmannP pushed a commit to HoffmannP/gitea that referenced this pull request Nov 14, 2018

Fix webhook type conflation. (go-gitea#4285)
- Fix typo that caused Gogs hooks to be created as Gitea hooks.
- Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one).

Signed-off-by: Russell Aunger <rba@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.