Ordering team by name ascending except for 'Owners' #45
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xBAADF00D can you make your original PR here instead of in Gogs repository? |
|
Waiting for @0xBAADF00D to PR another one. |
|
@DblK ok is will re-create PR within few hours. on |
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Feb 7, 2019
7 tasks
delvh
added
issue/not-a-bug
pieer
added a commit
to ikigau/gitea
that referenced
this pull request
Oct 27, 2025
…s in FishboneGraph
The FishboneGraph component was experiencing perceived slowness due to
on-demand loading with dynamic import. This created a double-delay:
1. Component code loading delay (dynamic import when tab clicked)
2. Data fetching delay (API call after component mounts)
Users had to wait for both delays sequentially, making the bubble view
feel slow to load.
Solution:
Changed from dynamic import to eager import:
Before:
```javascript
const {default: FishboneGraph} = await import('...FishboneGraph.vue');
```
After:
```javascript
import FishboneGraph from '../components/graph/FishboneGraph.vue';
```
Benefits:
- Component code is bundled with the main JavaScript bundle
- When user clicks bubble tab, only data fetch is needed
- Eliminates one network roundtrip (the dynamic import)
- Users see the loading skeleton immediately (from issue go-gitea#36)
- Perceived performance improvement: ~50% faster tab switching
Trade-off:
- Slightly larger initial bundle size (~100KB for FishboneGraph + dependencies)
- But this is acceptable since the bubble view is a core feature
- Modern browsers can handle this bundle size efficiently
The component still lazy-loads data via API (which is correct behavior),
but the component code itself is now immediately available.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of Gogs PR #3844