New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sudo functionality to the API #4809

Merged
merged 6 commits into from Sep 7, 2018

Conversation

7 participants
@zeripath
Contributor

zeripath commented Aug 28, 2018

Adds sudo functionality similar to https://docs.gitlab.com/ee/api/#sudo

@codecov-io

This comment has been minimized.

codecov-io commented Aug 28, 2018

Codecov Report

Merging #4809 into master will increase coverage by 0.04%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4809      +/-   ##
==========================================
+ Coverage   37.26%   37.31%   +0.04%     
==========================================
  Files         305      305              
  Lines       45170    45194      +24     
==========================================
+ Hits        16834    16863      +29     
+ Misses      25898    25892       -6     
- Partials     2438     2439       +1
Impacted Files Coverage Δ
routers/api/v1/api.go 75.37% <70.83%> (-0.25%) ⬇️
models/repo_list.go 57.71% <0%> (+1.34%) ⬆️
routers/api/v1/user/user.go 11.36% <0%> (+11.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a0381...00c6d90. Read the comment docs.

@lunny

This comment has been minimized.

Member

lunny commented Aug 28, 2018

CI failed

@zeripath zeripath force-pushed the zeripath:issue-4789 branch 4 times, most recently from 4096d80 to ab4adf3 Aug 28, 2018

@zeripath

This comment has been minimized.

Contributor

zeripath commented Aug 28, 2018

Have added a basic integration test - which after a small amount of hacking now works.

@lunny lunny added this to the 1.x.x milestone Aug 28, 2018

@zeripath zeripath force-pushed the zeripath:issue-4789 branch from 4ff4d1d to 7c21d34 Aug 28, 2018

@tboerger

This comment has been minimized.

Member

tboerger commented Aug 28, 2018

I personally don't like the naming sudo. I know such a feature as impersonate

@zeripath

This comment has been minimized.

Contributor

zeripath commented Aug 28, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Aug 29, 2018

@lafriks lafriks modified the milestones: 1.x.x, 1.6.0 Aug 29, 2018

@lafriks

This comment has been minimized.

Member

lafriks commented Aug 29, 2018

I'm ok with sudo :)

@zeripath zeripath force-pushed the zeripath:issue-4789 branch 2 times, most recently from d36f69a to 46dbb1e Aug 30, 2018

@zeripath

This comment has been minimized.

Contributor

zeripath commented Aug 30, 2018

I've just rebased to master, added some documentation and added the Sudo option to swagger as an authentication type.

Adding Sudo as an authentication type appears the easiest way to add it to the API and I guess it is a kind of authentication. Although I tried I couldn't seem to get swagger-generate to generate the file in such a way that Sudo requires another form of authentication.

## Sudo
The api allows admin users to sudo api requests as another user. Simply add either a `sudo=` parameter or `Sudo:` request header with the username of the user to sudo.

This comment has been minimized.

@lafriks

lafriks Aug 30, 2018

Member

Please use API in upper case in all places (docs, swagger docs etc)

This comment has been minimized.

@zeripath

zeripath Aug 30, 2018

Contributor

Fixed.

@zeripath zeripath force-pushed the zeripath:issue-4789 branch 4 times, most recently from 1b2e211 to 8109471 Aug 30, 2018

@zeripath zeripath force-pushed the zeripath:issue-4789 branch from 8109471 to 294829e Sep 1, 2018

@zeripath zeripath referenced this pull request Sep 5, 2018

Merged

Add support for gitea #187

zeripath added some commits Aug 28, 2018

Add sudo functionality
Signed-off-by: Andrew Thornton <art27@cantab.net>
Add simple integration test for sudo
Signed-off-by: Andrew Thornton <art27@cantab.net>
Add documentation and information to the swagger api
Signed-off-by: Andrew Thornton <art27@cantab.net>
Log that a sudo action has occurred
Signed-off-by: Andrew Thornton <art27@cantab.net>

@zeripath zeripath force-pushed the zeripath:issue-4789 branch from 294829e to af46b1b Sep 5, 2018

@lunny

lunny approved these changes Sep 7, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Sep 7, 2018

lunny added some commits Sep 7, 2018

@techknowlogick techknowlogick merged commit d293a2b into go-gitea:master Sep 7, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@zeripath zeripath deleted the zeripath:issue-4789 branch Sep 7, 2018

@lunny lunny referenced this pull request Sep 11, 2018

Closed

User impersonation #2883

2 of 7 tasks complete

aswild added a commit to aswild/gitea that referenced this pull request Oct 24, 2018

Merge tag 'v1.6.0-rc1'
Prepare for wild/v1.6 branch

* BREAKING
  * Respect email privacy option in user search via API (go-gitea#4512)
  * Simply remove tidb and deps (go-gitea#3993)
  * Swagger.v1.json template (go-gitea#3572)
* FEATURE
  * Pull request review/approval and comment on code (go-gitea#3748)
  * Added dependencies for issues (go-gitea#2196) (go-gitea#2531)
  * Add the ability to have built in themes in Gitea and provide dark theme arc-green (go-gitea#4198)
  * Add sudo functionality to the API (go-gitea#4809)
  * Add oauth providers via cli (go-gitea#4591)
  * Disable merging a WIP Pull request (go-gitea#4529)
  * Force user to change password (go-gitea#4489)
  * Add letsencrypt to Gitea (go-gitea#4189)
  * Add push webhook support for mirrored repositories (go-gitea#4127)
  * Add csv file render support defaultly (go-gitea#4105)
  * Add Recaptcha functionality to Gitea (go-gitea#4044)
* BUGFIXES
  * Fix release creation via API (go-gitea#5076)
  * Remove links from topics in edit mode  (go-gitea#5026)
  * Fix missing AppSubUrl in few more templates (fixup) (go-gitea#5021)
  * Fix missing AppSubUrl in some templates (go-gitea#5020)
  * Hide outdated comments in file view (go-gitea#5017)
  * Upgrade gopkg.in/testfixtures.v2 (go-gitea#4999)
  * Disable debug routes unless PPROF is enabled in configuration (go-gitea#4995)
  * Fix user menu item styling (go-gitea#4985)
  * Fix layout of the topics editing form (go-gitea#4971)
  * Fix null pointer dereference in ParseCommitWithSignature (go-gitea#4962)
  * Fix url in discord webhook (go-gitea#4953)
  * Detect charset and convert non UTF-8 files for display (go-gitea#4950)
  * Make sure to catch the right error so it is displayed on the UI (go-gitea#4945)
  * Fix(topics): don't redirect to explore page. (go-gitea#4938)
  * Fix bug forget to remove Stopwatch when remove repository (go-gitea#4928)
  * Fix bug when repo remained bare if multiple branches pushed in single push (go-gitea#4923)
  * Fix: Let's Encrypt configuration settings (go-gitea#4911)
  * Fix: Crippled diff (go-gitea#4726) (go-gitea#4900)
  * Fix trimming of markup section names (go-gitea#4863)
  * Issues api allow pulls and fix go-gitea#4832 (go-gitea#4852)
  * Do not autocreate directory for new users/orgs (go-gitea#4828) (go-gitea#4849)
  * Fix redirect with non-ascii branch names (go-gitea#4764) (go-gitea#4810)
  * Fix missing release title in webhook (go-gitea#4783) (go-gitea#4796)
  * User shouldn't be able to approve or reject his/her own PR (go-gitea#4729)
  * Make sure to reset commit count in the cache on mirror syncing (go-gitea#4720)
  * Fixed bug where team with admin privelege type doesn't get any unit  (go-gitea#4719)
  * Fix incorrect caption of webhook setting (go-gitea#4701) (go-gitea#4717)
  * Allow WIP marker to contains < or > (go-gitea#4709)
  * Hide org/create menu item in Dashboard if user has no rights (go-gitea#4678) (go-gitea#4680)
  * Site admin could create repos even MAX_CREATION_LIMIT=0 (go-gitea#4645)
  * Fix custom templates being ignored (go-gitea#4638)
  * Fix starring icon after semantic ui update (go-gitea#4628)
  * Fix Split-View line adjustment (go-gitea#4622)
  * Fix integer constant overflows in tests (go-gitea#4616)
  * Push whitelist now doesn't apply to branch deletion (go-gitea#4601) (go-gitea#4607)
  * Fix bugs when too many IN variables (go-gitea#4594)
  * Fix failure on creating pull request with assignees (go-gitea#4419) (go-gitea#4583)
  * Fix panic issue on update avatar email (go-gitea#4580) (go-gitea#4581)
  * Fix status code label for a successful webhook (go-gitea#4540)
  * An inactive user shouldn't be able to be added as a collaborator (go-gitea#4535)
  * Don't fail silently if trying to add a collaborator twice (go-gitea#4533)
  * Fix incorrect MergeWhitelistTeamIDs check in CanUserMerge function (go-gitea#4519) (go-gitea#4525)
  * Fix out-of-transaction query in removeOrgUser (go-gitea#4521) (go-gitea#4522)
  * Fix migration from older releases (go-gitea#4495)
  * Accept 'Data:' in commit graph (go-gitea#4487)
  * Update xorm to latest version and fix correct `user` table referencing in sql (go-gitea#4473)
  * Relative URLs for LibreJS page (go-gitea#4460)
  * Redirect to correct page after using scratch token (go-gitea#4458)
  * Fix column droping for MSSQL that need new transaction for that (go-gitea#4440)
  * Replace src with raw to fix image paths (go-gitea#4377)
  * Add default merge options when creating new repository (go-gitea#4369)
  * Fix docker build (go-gitea#4358)
  * Fixes repo membership check in API (go-gitea#4341)
  * Dep upgrade mysql lib (go-gitea#4161)
  * Fix some issues with special chars in branch names (go-gitea#3767)
  * Responsive design fixes (go-gitea#4508)
* ENHANCEMENT
  * Fix milestones sorted wrongly (go-gitea#4987)
  * Allow api to create tags for releases if they don't exist (go-gitea#4890)
  * Fix go-gitea#4877 to follow the OpenID Connect Audiences spec (go-gitea#4878)
  * Enforce token on api routes [fixed critical security issue go-gitea#4357] (go-gitea#4840)
  * Update legacy branch and tag URLs in dashboard to new format (go-gitea#4812)
  * Slack webhook channel name cannot be empty or just contain an hashtag (go-gitea#4786)
  * Add whitespace handling to PR-comparsion (go-gitea#4683)
  * Make reverse proxy auth optional (go-gitea#4643)
  * MySQL TLS (go-gitea#4642)
  * Make sure to set PR split view when creating/previewing a pull request  (go-gitea#4617)
  * Log user in after a successful sign up (go-gitea#4615)
  * Fix typo IsPullReuqestBroken -> IsPullRequestBroken (go-gitea#4578)
  * Allow admin toggle forcing a password change for newly created users (go-gitea#4563)
  * Update jQuery to v1.12.4 (go-gitea#4551)
  * Env var GITEA_PUSHER_EMAIL (go-gitea#4516)
  * Feat(repo): support search repository by topic name (go-gitea#4505)
  * Small improvements to dependency UI (go-gitea#4503)
  * Make max commits in graph configurable (go-gitea#4498)
  * Add valid for lfs oid (go-gitea#4461)
  * Add shortcut to save wiki page (go-gitea#4452)
  * Allow administrator to create repository for any organization (go-gitea#4368)
  * Fix repository last updated time update when delete a user who watched the repo (go-gitea#4363)
  * Switch plaintext scratch tokens to use hash instead (go-gitea#4331)
  * Increase default TOTP secret size to 320 bits (go-gitea#4287)
  * Keep preseeded database password (go-gitea#4284)
  * Implemented hover text showing user FullName (go-gitea#4261)
  * Add ability to delete a token (go-gitea#4235)
  * Fix typos in i18n variable names. (go-gitea#4080)
  * Api: repos/search: add parameters to control the sort order (go-gitea#3964)
  * Add missing path in the Docker app.ini template (go-gitea#2181)
  * Add file name and branch to page title (go-gitea#4902)
  * Offline use of google fonts (go-gitea#4872)
  * Add missing History link to directory listings v2 (go-gitea#4829)
  * Locale for Edit and Remove due date issue (go-gitea#4802)
  * Disable 'May Import Local Repository' when is disabled by setting (Is… (go-gitea#4780)
  * API /admin/users/{username} missing parameter (go-gitea#4775)
  * Display error when adding a user to a team twice (go-gitea#4746)
  * Remove UsePrivilegeSeparation from the Docker sshd_config, see go-gitea#2876 (go-gitea#4722)
  * Focus title input when clicking helper link (go-gitea#4696)
  * Add vendor to user reserved words and format words list according alphabet (go-gitea#4685)
  * Add gitea/issues link to 500 page (go-gitea#4654)
  * Hide home button when landing page is not set to home (go-gitea#4651)
  * Remove link to GitHub issues in 404 template (go-gitea#4639)
  * Cmd/serve: pprof cpu and memory profile dumps to disk (go-gitea#4560)
  * Add flash message after an account has been successfully activated (go-gitea#4510)
  * Prevent html entity escaping on delete branch (go-gitea#4471)
  * Locale for button Edit on protected branch (go-gitea#4442)
  * Update notification icon (go-gitea#4343)
  * Added front-end topics validation (go-gitea#4316)
  * Don't display buttons if there are no system notifications (go-gitea#4280)
  * Issue due date api (go-gitea#3890)
* SECURITY
  * Improve URL validation for external wiki  and external issues (go-gitea#4710)
  * Make cookies HttpOnly and obey COOKIE_SECURE flag (go-gitea#4706)
  * Don't disclose emails of all users when sending out emails (go-gitea#4664)
  * Check that repositories can only be migrated to own user or organizations (go-gitea#4366)
* TRANSLATION
  * Fix punctuation in English translation (go-gitea#4958)
  * Fix translation (go-gitea#4355)

@lafriks lafriks added the changelog label Nov 10, 2018

HoffmannP pushed a commit to HoffmannP/gitea that referenced this pull request Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment