New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: fix crippled diff (#4726) #4929

Merged
merged 4 commits into from Sep 14, 2018

Conversation

7 participants
@xxxtonixxx
Contributor

xxxtonixxx commented Sep 13, 2018

Backport of #4900

@SagePtr

This comment has been minimized.

Contributor

SagePtr commented Sep 13, 2018

And make regenerate-stylesheet for this too (because it's quite different on different branches)

@bkcsoft bkcsoft added the lgtm/need 2 label Sep 13, 2018

ci
@xxxtonixxx

This comment has been minimized.

Contributor

xxxtonixxx commented Sep 13, 2018

@SagePtr, I commited with styles regenerated 😕 I have pushed an empty commit, but it's still failing

What can I do?

@techknowlogick

This comment has been minimized.

Member

techknowlogick commented Sep 13, 2018

@xxxtonixxx it may be that you need to rm -rf node_modules and npm i it again before building. I know there was a change to the less library that caused a different output

@xxxtonixxx

This comment has been minimized.

Contributor

xxxtonixxx commented Sep 13, 2018

Thanks @techknowlogick, it was! 🎉

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Sep 13, 2018

@lafriks lafriks added the kind/bug label Sep 14, 2018

@lafriks lafriks added this to the 1.5.2 milestone Sep 14, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Sep 14, 2018

@JonasFranzDEV JonasFranzDEV merged commit 177b46f into go-gitea:release/v1.5 Sep 14, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@oscarlofwenhamn

This comment has been minimized.

oscarlofwenhamn commented Nov 21, 2018

@xxxtonixxx it may be that you need to rm -rf node_modules and npm i it again before building. I know there was a change to the less library that caused a different output

I am having a similar error,
Is this to be done in the gitea root folder or more so in the npm install folder?

@xxxtonixxx

This comment has been minimized.

Contributor

xxxtonixxx commented Nov 21, 2018

In the gitea root folder, @oscarlofwenhamn

@oscarlofwenhamn

This comment has been minimized.

oscarlofwenhamn commented Nov 21, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment