New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix url in discord webhook #4951

Merged
merged 1 commit into from Sep 18, 2018

Conversation

7 participants
@esno
Contributor

esno commented Sep 17, 2018

opening issues generates a webhook to discord that contains
a url to the gitea api. the message title in discord is therefore
referencing to the api instead of the issue itself.

fix url in discord webhook
opening issues generates a webhook to discord that contains
a url to the gitea api. the message title in discord is therefore
referencing to the api instead of the issue itself.

@appleboy appleboy added the kind/bug label Sep 18, 2018

@appleboy appleboy added this to the 1.6.0 milestone Sep 18, 2018

@bkcsoft bkcsoft added the lgtm/need 1 label Sep 18, 2018

@lunny

lunny approved these changes Sep 18, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Sep 18, 2018

@lunny lunny added the backport/v1.5 label Sep 18, 2018

@lafriks lafriks merged commit 4176e33 into go-gitea:release/v1.5 Sep 18, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@lafriks

This comment has been minimized.

Member

lafriks commented Sep 18, 2018

Please send backport to release/v1.5 branch

@lafriks

This comment has been minimized.

Member

lafriks commented Sep 18, 2018

Oh I just noticed that this PR is for release/v1.5 branch. You should send PR to master branch first next time. Please backport to master than.

@lafriks lafriks modified the milestones: 1.6.0, 1.5.2 Sep 18, 2018

@esno esno referenced this pull request Sep 18, 2018

Merged

fix url in discord webhook #4953

@esno

This comment has been minimized.

Contributor

esno commented Sep 18, 2018

was late yesterday. sorry for that

@adelowo

This comment has been minimized.

Member

adelowo commented Sep 18, 2018

Is this a fix for #4656 ?

@lunny

This comment has been minimized.

Member

lunny commented Sep 18, 2018

@adelowo yes

@esno

This comment has been minimized.

Contributor

esno commented Sep 18, 2018

thx @adelowo for pointing out that issue number. that's exactly the issue that is addressed by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment