New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore list #5258

Merged
merged 4 commits into from Nov 3, 2018

Conversation

5 participants
@sapk
Copy link
Member

sapk commented Nov 2, 2018

fix #5257

The script https://github.com/go-gitea/gitea/blob/master/scripts/generate-gitignores.go need to be updated to handle link in the gitignore repo.

@sapk sapk force-pushed the sapk-fork:updt-gitignore branch from 61f0d5b to 5e36ff8 Nov 2, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 2, 2018

Codecov Report

Merging #5258 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5258      +/-   ##
==========================================
+ Coverage   37.61%   37.62%   +<.01%     
==========================================
  Files         310      310              
  Lines       46042    46042              
==========================================
+ Hits        17320    17322       +2     
+ Misses      26243    26241       -2     
  Partials     2479     2479
Impacted Files Coverage Δ
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54259e2...4cce604. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Nov 2, 2018

@techknowlogick techknowlogick added this to the 1.7.0 milestone Nov 2, 2018

@sapk sapk changed the title [WIP] Update gitignore list Update gitignore list Nov 2, 2018

@sapk

This comment has been minimized.

Copy link
Member

sapk commented Nov 2, 2018

This PR is ready for review.
I updated the script https://github.com/go-gitea/gitea/pull/5258/files#diff-fd99876caac1c11beb1c52ab37fb58f7 to copy content of symlink (Clojure, Fortran, Kotlin) in the source tar (to be sure to be compatible with windows).

@lafriks

lafriks approved these changes Nov 3, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Nov 3, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Nov 3, 2018

@techknowlogick techknowlogick merged commit 57a8440 into go-gitea:master Nov 3, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@sapk sapk deleted the sapk-fork:updt-gitignore branch Nov 3, 2018

HoffmannP pushed a commit to HoffmannP/gitea that referenced this pull request Nov 14, 2018

Update gitignore list (go-gitea#5258)
* update gitignore

* Handle symlink in tar

* Add some logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment