New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pasting image from clipboard for browsers that supports that #5317

Merged
merged 5 commits into from Nov 15, 2018

Conversation

5 participants
@lafriks
Copy link
Member

lafriks commented Nov 11, 2018

Fixes #3032

Implemented in new issue text area and when adding issue/pr comments

lafriks added some commits Nov 11, 2018

@lafriks lafriks added this to the 1.7.0 milestone Nov 11, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 11, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@e110943). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5317   +/-   ##
=========================================
  Coverage          ?   37.36%           
=========================================
  Files             ?      312           
  Lines             ?    46399           
  Branches          ?        0           
=========================================
  Hits              ?    17339           
  Misses            ?    26576           
  Partials          ?     2484

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e110943...8b77e79. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Nov 11, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Nov 12, 2018

It seems it's not work for me. Chrome 70.0.3538.77 on macOS

@lafriks

This comment has been minimized.

Copy link
Member Author

lafriks commented Nov 12, 2018

@lunny do you get any error in JavaScript console?

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Nov 12, 2018

@lafriks no any error on console.

@lafriks

This comment has been minimized.

Copy link
Member Author

lafriks commented Nov 12, 2018

@lunny can you describe steps you did?

Update to cancel original paste event on case there is also text
In Safari there can be both image and text
@lafriks

This comment has been minimized.

Copy link
Member Author

lafriks commented Nov 12, 2018

@lunny I just tested and it worked on both chrome and safari on Mac. Try pressing Ctrl+F5 or clearing cache, could be browser was using cached javascript version

@lunny

lunny approved these changes Nov 14, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Nov 14, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Nov 15, 2018

@techknowlogick techknowlogick merged commit 7278372 into go-gitea:master Nov 15, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks deleted the lafriks:feat/comment_image_paste branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment