New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependent issue searching when gitea is run in subpath #5392

Merged
merged 4 commits into from Nov 25, 2018

Conversation

7 participants
@lafriks
Copy link
Member

lafriks commented Nov 23, 2018

Fixes #5389

@lafriks lafriks added this to the 1.7.0 milestone Nov 23, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 23, 2018

Codecov Report

Merging #5392 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5392      +/-   ##
==========================================
- Coverage   37.45%   37.45%   -0.01%     
==========================================
  Files         312      312              
  Lines       46509    46509              
==========================================
- Hits        17419    17418       -1     
  Misses      26599    26599              
- Partials     2491     2492       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e587e0...0cf404a. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Nov 23, 2018

@Bwko

Bwko approved these changes Nov 24, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Nov 24, 2018

@MarkusAmshove

This comment has been minimized.

Copy link

MarkusAmshove commented Nov 24, 2018

I can confirm that this works :)

@lunny

lunny approved these changes Nov 25, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Nov 25, 2018

lunny and others added some commits Nov 25, 2018

@techknowlogick techknowlogick merged commit 499d132 into go-gitea:master Nov 25, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Nov 25, 2018

@lafriks please send backport 😄

@lafriks lafriks deleted the lafriks:fix/dep_suburl_repolink branch Nov 25, 2018

lafriks added a commit to lafriks/gitea that referenced this pull request Nov 25, 2018

techknowlogick added a commit that referenced this pull request Nov 26, 2018

@lunny lunny referenced this pull request Dec 8, 2018

Closed

Adding issue dependencies is defunct in 1.6.0 #5483

1 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment