New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alpine to 3.8 #5423

Merged
merged 4 commits into from Nov 29, 2018

Conversation

6 participants
@techknowlogick
Copy link
Member

techknowlogick commented Nov 28, 2018

As title

@techknowlogick techknowlogick added this to the 1.7.0 milestone Nov 28, 2018

@bkcsoft bkcsoft added the lgtm/need 1 label Nov 28, 2018

@gaydin

This comment has been minimized.

Copy link
Contributor

gaydin commented Nov 28, 2018

Is it possible to upgrade to 3.8 too?

FROM golang:1.11-alpine3.7 AS build-env

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Nov 28, 2018

@gaydin yup. Thank you for the suggestion. I've updated.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #5423 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5423      +/-   ##
==========================================
- Coverage   37.55%   37.54%   -0.01%     
==========================================
  Files         317      317              
  Lines       46832    46832              
==========================================
- Hits        17588    17585       -3     
- Misses      26744    26746       +2     
- Partials     2500     2501       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc805c...7271bff. Read the comment docs.

@lunny

lunny approved these changes Nov 29, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Nov 29, 2018

@techknowlogick techknowlogick merged commit 5c13ba8 into go-gitea:master Nov 29, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@techknowlogick techknowlogick deleted the techknowlogick:techknowlogick-patch-9 branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment