New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport]word-break the WebHook url to prevent a ui-break #5445

Merged
merged 2 commits into from Dec 2, 2018

Conversation

5 participants
@romankl
Copy link
Contributor

romankl commented Dec 2, 2018

the requested backport for #5432

right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class dont-break-out
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
text text-break-word, but that would duplicate the dont-break-out
class just for text elements that use the text class.

fixes: #5416

word-break the WebHook url to prevent a ui-break
right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class `dont-break-out`
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
`text text-break-word`, but that would duplicate the `dont-break-out`
class just for text elements that use the `text` class.

fixes: #5416
Signed-off-by: Roman <romaaan.git@gmail.com>
@lunny

lunny approved these changes Dec 2, 2018

@bkcsoft bkcsoft added the lgtm/need 1 label Dec 2, 2018

@lafriks lafriks added the kind/bug label Dec 2, 2018

@lafriks lafriks added this to the 1.6.1 milestone Dec 2, 2018

@lafriks

lafriks approved these changes Dec 2, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 2, 2018

@techknowlogick techknowlogick merged commit 7bc1faa into go-gitea:release/v1.6 Dec 2, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@romankl romankl deleted the romankl:r-backport-url-wrap-in-webhooks branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment