New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add require attribute to target param on releases #5477

wants to merge 3 commits into
base: master


3 participants

techknowlogick commented Dec 5, 2018

Fix #5471

commands I ran to get to this point:

cd go/src/
git pull
git checkout -b issue-5471
dep ensure -update
git add .
git commit -m "update sdk vendor"
git push origin issue-5471

techknowlogick added some commits Dec 5, 2018


This comment has been minimized.


techknowlogick commented Dec 5, 2018

blocked by #5419


This comment has been minimized.

codecov-io commented Dec 5, 2018

Codecov Report

Merging #5477 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5477      +/-   ##
+ Coverage   37.56%   37.57%   +<.01%     
  Files         317      317              
  Lines       46824    46824              
+ Hits        17591    17593       +2     
+ Misses      26734    26732       -2     
  Partials     2499     2499
Impacted Files Coverage Δ
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b864a3...ab2ce74. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment