New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix forgot deletion of notification when delete repository #5506

Merged
merged 2 commits into from Dec 10, 2018

Conversation

5 participants
@lunny
Copy link
Member

lunny commented Dec 9, 2018

will fix #3105

@lunny lunny added this to the 1.7.0 milestone Dec 9, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 9, 2018

Codecov Report

Merging #5506 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5506      +/-   ##
==========================================
- Coverage   37.64%   37.63%   -0.01%     
==========================================
  Files         317      317              
  Lines       46827    46828       +1     
==========================================
  Hits        17626    17626              
- Misses      26700    26701       +1     
  Partials     2501     2501
Impacted Files Coverage Δ
models/repo.go 42.78% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 928417a...7dfd013. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Dec 9, 2018

@lafriks

lafriks approved these changes Dec 9, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Dec 9, 2018

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Dec 9, 2018

Don't we need migration for this?

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Dec 10, 2018

@lafriks I will send another PR to v1.7 but not back port to migrate because we cannot add migration on v1.6. When user upgrade from v1.6 to v1.7, the migration will be triggered.

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 10, 2018

@lafriks lafriks merged commit 1b3404e into go-gitea:master Dec 10, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

lunny added a commit to lunny/gitea that referenced this pull request Dec 11, 2018

@lunny lunny added the backport/done label Dec 11, 2018

@lunny lunny deleted the lunny:lunny/del_notification_when_del_repo branch Dec 11, 2018

lunny added a commit that referenced this pull request Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment