New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix detect force push failure on deletion of protected branches #5522

Merged
merged 3 commits into from Dec 12, 2018

Conversation

6 participants
@lunny
Copy link
Member

lunny commented Dec 11, 2018

should fix #2631

@lunny lunny added this to the 1.7.0 milestone Dec 11, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #5522 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5522      +/-   ##
==========================================
+ Coverage   37.57%   37.58%   +<.01%     
==========================================
  Files         319      319              
  Lines       46949    46949              
==========================================
+ Hits        17642    17645       +3     
+ Misses      26795    26793       -2     
+ Partials     2512     2511       -1
Impacted Files Coverage Δ
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db7dbd...3cc2d65. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Dec 11, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Dec 11, 2018

@Bwko

Bwko approved these changes Dec 11, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 11, 2018

techknowlogick and others added some commits Dec 11, 2018

@lafriks lafriks merged commit af6bce3 into go-gitea:master Dec 12, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Dec 12, 2018

@lunny please backport

@lunny lunny deleted the lunny:lunny/fix_protected_branch_deletion branch Dec 12, 2018

lunny added a commit to lunny/gitea that referenced this pull request Dec 12, 2018

@lunny lunny added the backport/done label Dec 12, 2018

techknowlogick added a commit that referenced this pull request Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment