New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drone/mssql: use golang 1.11 #5586

Merged
merged 1 commit into from Dec 23, 2018

Conversation

5 participants
@sapk
Copy link
Member

sapk commented Dec 23, 2018

Seems that mssql tests were stuck in golang:1.10.
Others tests use golang:1.11

@sapk sapk changed the title drone/mssql: use golang 1.11 build like the other tests drone/mssql: use golang 1.11 build like other tests Dec 23, 2018

@sapk sapk changed the title drone/mssql: use golang 1.11 build like other tests drone/mssql: use golang 1.11 Dec 23, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 23, 2018

Codecov Report

Merging #5586 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5586      +/-   ##
==========================================
- Coverage   37.55%   37.54%   -0.01%     
==========================================
  Files         321      321              
  Lines       47206    47206              
==========================================
- Hits        17729    17725       -4     
- Misses      26932    26936       +4     
  Partials     2545     2545
Impacted Files Coverage Δ
routers/repo/view.go 44.78% <0%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06ae0b...45920a3. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Dec 23, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Dec 23, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 23, 2018

@lafriks lafriks merged commit 9f544e9 into go-gitea:master Dec 23, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@sapk sapk deleted the sapk-fork:updt-mssql-test branch Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment