New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlite deadlock when assigning to a PR (#5640) (Backport to v1.7) #5642

Merged
merged 1 commit into from Jan 5, 2019

Conversation

5 participants
@zeripath
Copy link
Contributor

zeripath commented Jan 5, 2019

When assigning a user to a PR there was a call to issue.PullRequest.APIFormat() which causes an deadlock in sqlite due to the internal use of the xorm engine. This PR changes this to issue.PullRequest.apiFormat(sess) passing in the current session and thus avoiding the deadlock.

Fix #5639

Fix sqlite deadlock when assigning to a PR (#5640)
* Fix sqlite deadlock when assigning to a PR

Fix 5639

Signed-off-by: Andrew Thornton <art27@cantab.net>

* More possible deadlocks found and fixed

Signed-off-by: Andrew Thornton <art27@cantab.net>
@lunny

lunny approved these changes Jan 5, 2019

@bkcsoft bkcsoft added the lgtm/need 1 label Jan 5, 2019

@lunny lunny added this to the 1.7.0 milestone Jan 5, 2019

@lunny lunny added the kind/bug label Jan 5, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jan 5, 2019

backport from #5640

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 5, 2019

@techknowlogick techknowlogick merged commit 2904d8d into go-gitea:release/v1.7 Jan 5, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@zeripath zeripath deleted the zeripath:issue-5639-fix-deadlock branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment