New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display branch name in delete branch confirmation modal. #5654

Merged
merged 2 commits into from Jan 6, 2019

Conversation

6 participants
@HarshitOnGitHub
Copy link
Contributor

HarshitOnGitHub commented Jan 6, 2019

Fixes: #5630.

Screenshots:
Before:
image

After:
image

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #5654 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5654      +/-   ##
==========================================
- Coverage   37.85%   37.84%   -0.01%     
==========================================
  Files         322      322              
  Lines       47498    47498              
==========================================
- Hits        17980    17977       -3     
- Misses      26931    26936       +5     
+ Partials     2587     2585       -2
Impacted Files Coverage Δ
modules/indexer/repo.go 63.35% <0%> (-5.35%) ⬇️
models/repo_indexer.go 48.3% <0%> (-1.7%) ⬇️
routers/repo/view.go 46.01% <0%> (+1.22%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42bde7...b16e5ab. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Jan 6, 2019

@lafriks lafriks added the kind/ui label Jan 6, 2019

@lafriks

lafriks approved these changes Jan 6, 2019

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jan 6, 2019

@adelowo

adelowo approved these changes Jan 6, 2019

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 6, 2019

@techknowlogick techknowlogick merged commit dd006db into go-gitea:master Jan 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks added this to the 1.8.0 milestone Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment