New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for user specific themes #5668

Merged
merged 12 commits into from Jan 9, 2019

Conversation

6 participants
@adelowo
Copy link
Member

adelowo commented Jan 8, 2019

Fixes #5281

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #5668 into master will decrease coverage by 0.01%.
The diff coverage is 14.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5668      +/-   ##
==========================================
- Coverage   37.79%   37.77%   -0.02%     
==========================================
  Files         322      323       +1     
  Lines       47544    47592      +48     
==========================================
+ Hits        17968    17977       +9     
- Misses      26987    27026      +39     
  Partials     2589     2589
Impacted Files Coverage Δ
models/migrations/migrations.go 2.61% <ø> (ø) ⬆️
modules/setting/setting.go 48.8% <ø> (ø) ⬆️
modules/auth/user_form.go 41.81% <0%> (-9.3%) ⬇️
models/migrations/v77.go 0% <0%> (ø)
routers/user/setting/account.go 26.66% <0%> (-4.59%) ⬇️
routers/routes/routes.go 85.05% <100%> (+0.04%) ⬆️
models/user.go 48.14% <62.5%> (+0.11%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea51868...b2471cb. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Jan 8, 2019

adelowo added some commits Jan 8, 2019

@adelowo adelowo changed the title WIP: Allow for user specific themes Allow for user specific themes Jan 9, 2019

@adelowo

This comment has been minimized.

Copy link
Member

adelowo commented Jan 9, 2019

Removed WIP as it has been completed now

@xmrdsc

xmrdsc approved these changes Jan 9, 2019

Show resolved Hide resolved models/user.go Outdated
Show resolved Hide resolved modules/auth/user_form.go Outdated
Show resolved Hide resolved models/migrations/v77.go Outdated

@lunny lunny added this to the 1.8.0 milestone Jan 9, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jan 9, 2019

[...itea/routers/init.go:61 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: mssql: ALTER TABLE only allows columns to be added that can contain nulls, or have a DEFAULT definition specified, or the column being added is an identity or timestamp column, or alternatively if none of the previous conditions are satisfied the table must be empty to allow addition of this column. Column 'theme' cannot be added to non-empty table 'user' because it does not satisfy these conditions.

adelowo added some commits Jan 9, 2019

@lunny

lunny approved these changes Jan 9, 2019

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jan 9, 2019

@lunny lunny added the changelog label Jan 9, 2019

@bkcsoft bkcsoft removed the lgtm/need 1 label Jan 9, 2019

@bkcsoft bkcsoft added the lgtm/done label Jan 9, 2019

@techknowlogick techknowlogick merged commit 8d2c24f into go-gitea:master Jan 9, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@adelowo adelowo deleted the adelowo:allow_user_defined_themes branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment