New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix public will not be reused as public key after deleting as deploy key #5671

Merged
merged 3 commits into from Jan 9, 2019

Conversation

6 participants
@lunny
Copy link
Member

lunny commented Jan 9, 2019

Will fix #1357

@lunny lunny added this to the 1.8.0 milestone Jan 9, 2019

@lunny lunny referenced this pull request Jan 9, 2019

Closed

SSH key doesn't get deleted #4348

0 of 5 tasks complete
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 9, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@530c2b8). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5671   +/-   ##
=========================================
  Coverage          ?   37.77%           
=========================================
  Files             ?      323           
  Lines             ?    47595           
  Branches          ?        0           
=========================================
  Hits              ?    17977           
  Misses            ?    27029           
  Partials          ?     2589
Impacted Files Coverage Δ
models/ssh_key.go 40.23% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530c2b8...8c770b9. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Jan 9, 2019

@zeripath
Copy link
Contributor

zeripath left a comment

Oh dear, I think I've looked at this code before and wondered why it didn't need to rewrite the public keys! Turns out it did!!

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jan 9, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jan 9, 2019

@zeripath I just take a look and found the problem. Sorry to post a PR before you! :)

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Jan 9, 2019

No probs, as I said, I saw it and ignored it. That'll teach me! I think I may just need to be more suspicious.

@adelowo

adelowo approved these changes Jan 9, 2019

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 9, 2019

techknowlogick added some commits Jan 9, 2019

@techknowlogick techknowlogick merged commit 0b84b5e into go-gitea:master Jan 9, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

lunny added a commit to lunny/gitea that referenced this pull request Jan 10, 2019

lunny added a commit to lunny/gitea that referenced this pull request Jan 10, 2019

@lunny lunny deleted the lunny:lunny/fix_del_deploy_key_not_reuse branch Jan 10, 2019

@lunny lunny added the backport/done label Jan 10, 2019

techknowlogick added a commit that referenced this pull request Jan 10, 2019

techknowlogick added a commit that referenced this pull request Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment