New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Fork button" for guests by showing a pop up asking them to log in before forking #5690

Merged
merged 3 commits into from Jan 11, 2019

Conversation

6 participants
@adelowo
Copy link
Member

adelowo commented Jan 10, 2019

Allow users fork a repo even as a guest. This will prompt the user to log in and if authentication was successful, the user will be redirected to fork the repo

Fixes #4798

screenshot 2019-01-10 at 17 35 58

allow user fork repo even when as a guest.. This will prompt the user…
… to login and if authentication was successful, the user will be redirected to fork the repo
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 10, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@6630a33). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5690   +/-   ##
=========================================
  Coverage          ?   37.77%           
=========================================
  Files             ?      323           
  Lines             ?    47595           
  Branches          ?        0           
=========================================
  Hits              ?    17977           
  Misses            ?    27029           
  Partials          ?     2589

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6630a33...55fd2eb. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Jan 10, 2019

@lafriks lafriks added this to the 1.8.0 milestone Jan 10, 2019

@adelowo

This comment has been minimized.

Copy link
Member

adelowo commented Jan 10, 2019

What happened to the lgtm bot :)

Edit —

Is the bot supposed to consider the PR creator’s “lgtm” ?

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jan 10, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jan 11, 2019

@adelowo that's a bug of the bot.

@lunny

lunny approved these changes Jan 11, 2019

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 11, 2019

techknowlogick added some commits Jan 11, 2019

@techknowlogick techknowlogick merged commit abb364f into go-gitea:master Jan 11, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@adelowo adelowo deleted the adelowo:fork_button_should_be_clickable branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment