New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS errors when using acme/autocert for local connections (#5820) #5826

Merged
merged 1 commit into from Jan 24, 2019

Conversation

4 participants
@joohoi
Copy link
Contributor

joohoi commented Jan 24, 2019

Backport of #5820

@bkcsoft bkcsoft added the lgtm/need 1 label Jan 24, 2019

@lafriks lafriks added the kind/bug label Jan 24, 2019

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 24, 2019

@lafriks lafriks added this to the 1.7.1 milestone Jan 24, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Jan 24, 2019

Thanks @joohoi for your work. I wasn't able to setup a suitable test environment but I hope that my code diving was helpful in pointing you to where your needed to fix this.

@lafriks lafriks merged commit f635041 into go-gitea:release/v1.7 Jan 24, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks changed the title [Backport] Fix TLS errors when using acme/autocert for local connections Fix TLS errors when using acme/autocert for local connections (#5820) Jan 24, 2019

@joohoi

This comment has been minimized.

Copy link
Contributor Author

joohoi commented Jan 24, 2019

I wasn't able to setup a suitable test environment but I hope that my code diving was helpful in pointing you to where your needed to fix this.

It totally was! I made a wrong assumption in the initial issue, and the resulting fix would have taken quite a bit longer without the pointers, thanks! This was my first look into Gitea codebase altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment