New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete correct temp directory #5839

Merged
merged 2 commits into from Jan 25, 2019

Conversation

@yasuokav
Copy link
Contributor

yasuokav commented Jan 25, 2019

This PR will fix #5829

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #5839 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5839      +/-   ##
==========================================
+ Coverage   37.86%   37.88%   +0.01%     
==========================================
  Files         328      328              
  Lines       48310    48310              
==========================================
+ Hits        18294    18303       +9     
+ Misses      27385    27380       -5     
+ Partials     2631     2627       -4
Impacted Files Coverage Δ
models/pull.go 50.95% <100%> (ø) ⬆️
models/repo_indexer.go 48.3% <0%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892bfd0...8ab2aff. Read the comment docs.

@lunny

lunny approved these changes Jan 25, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jan 25, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 25, 2019

@lafriks lafriks added this to the 1.8.0 milestone Jan 25, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Jan 25, 2019

Looks like it's the intermittent MSSQL failure again...

@techknowlogick techknowlogick merged commit d663930 into go-gitea:master Jan 25, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@yasuokav yasuokav deleted the yasuokav:fix-delete-unique-tmpdir branch Jan 26, 2019

bmackinney added a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment