New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to list tags #5850

Merged
merged 7 commits into from Feb 7, 2019

Conversation

@lunny
Copy link
Member

lunny commented Jan 25, 2019

blocked by go-gitea/go-sdk#139

blocked by go-gitea/git#143

@kolaente
Copy link
Member

kolaente left a comment

Please generate swagger docs.

@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 26, 2019

@lunny lunny force-pushed the lunny:lunny/list_tags branch from 93514db to 1f3f41b Jan 28, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

lunny commented Jan 28, 2019

should fix #5693

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #5850 into master will increase coverage by 0.04%.
The diff coverage is 87.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5850      +/-   ##
==========================================
+ Coverage   38.71%   38.76%   +0.04%     
==========================================
  Files         330      332       +2     
  Lines       48884    48938      +54     
==========================================
+ Hits        18924    18969      +45     
- Misses      27215    27222       +7     
- Partials     2745     2747       +2
Impacted Files Coverage Δ
routers/api/v1/convert/convert.go 79.26% <100%> (+1.78%) ⬆️
routers/api/v1/api.go 73.89% <100%> (+0.15%) ⬆️
models/repo_tag.go 62.5% <62.5%> (ø)
routers/api/v1/repo/tag.go 86.66% <86.66%> (ø)
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d213b6...b405f9d. Read the comment docs.

@techknowlogick
Copy link
Member

techknowlogick left a comment

Please add API tests

@lunny lunny force-pushed the lunny:lunny/list_tags branch from e28bdda to 19c6886 Feb 6, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 7, 2019

lunny added some commits Jan 25, 2019

@lunny lunny force-pushed the lunny:lunny/list_tags branch from 19c6886 to 8a91ad5 Feb 7, 2019

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Feb 7, 2019

@kolaente need your approval

@sapk

sapk approved these changes Feb 7, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 7, 2019

@zeripath zeripath merged commit 01bbf5e into go-gitea:master Feb 7, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lunny lunny deleted the lunny:lunny/list_tags branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment