/gitea

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compare button on upstream repo leading to 404 #5877

Merged
merged 5 commits into from Jan 29, 2019
+2 −2

Conversation

Reviewers

@techknowlogick techknowlogick

@zeripath zeripath

Assignees
No one assigned
Labels
kind/bug kind/ui lgtm/done
Milestone
  1.8.0
6 participants
@adelowo @codecov-io @lunny @techknowlogick @zeripath @GiteaBot
@adelowo
Copy link
Member

adelowo commented Jan 28, 2019

Fixes #3727
@adelowo
fix compare button on upstream repo leading to 404
Verified
This commit was signed with a verified signature.
@adelowo adelowo Lanre Adelowo
GPG key ID: 41158467DC7A741F Learn about signing commits
Loading status checks…
b1582cc
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Jan 28, 2019 •
edited

Codecov Report

Merging #5877 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5877      +/-   ##
=========================================
- Coverage      38%     38%   -0.01%     
=========================================
  Files         328     328              
  Lines       48331   48331              
=========================================
- Hits        18370   18366       -4     
- Misses      27322   27327       +5     
+ Partials     2639    2638       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 46.1% <0%> (-1.2%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62c0b6...d9c13d5. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Jan 28, 2019

@adelowo
Merge branch 'master' into fix_3727
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6943ebc

@techknowlogick techknowlogick added the kind/ui label Jan 28, 2019

@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 28, 2019

@techknowlogick techknowlogick added the kind/bug label Jan 28, 2019

@adelowo
Merge branch 'master' into fix_3727
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
368b1ab
@zeripath

zeripath approved these changes Jan 29, 2019
View changes

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jan 29, 2019

@techknowlogick
Merge branch 'master' into fix_3727
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dae6a8c
@techknowlogick

techknowlogick approved these changes Jan 29, 2019
View changes

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 29, 2019

@techknowlogick
Merge branch 'master' into fix_3727
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d9c13d5

@techknowlogick techknowlogick merged commit 16678f5 into go-gitea:master Jan 29, 2019
2 checks passed

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@adelowo adelowo deleted the adelowo:fix_3727 branch Jan 29, 2019

@lunny

This comment has been minimized.

Sign in to view
Copy link
Member

lunny commented Jan 31, 2019

Please send a backport to releases/v1.7

adelowo added a commit to adelowo/gitea that referenced this pull request Jan 31, 2019

@adelowo
fix compare button on upstream repo leading to 404 (go-gitea#5877)
Verified
This commit was signed with a verified signature.
@adelowo adelowo Lanre Adelowo
GPG key ID: 41158467DC7A741F Learn about signing commits
4e96cf0

@adelowo adelowo referenced this pull request Jan 31, 2019

Merged

fix compare button on upstream repo leading to 404 (Backport of #5877) #5914

techknowlogick added a commit that referenced this pull request Jan 31, 2019

@adelowo @techknowlogick
fix compare button on upstream repo leading to 404 (#5877) (#5914)
Loading status checks…
5c30817

@juanpablo-santos juanpablo-santos referenced this pull request Feb 1, 2019

Closed

Incorrect URL for compare button on non forked repos not owned by user #5924

0 of 5 tasks complete

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 1, 2019

@zeripath
Revert go-gitea#5877 
This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>
Verified
This commit was signed with a verified signature.
@zeripath zeripath
GPG key ID: 3CDE74631F13A748 Learn about signing commits
d6eb157

@zeripath zeripath referenced this pull request Feb 1, 2019

Merged

Issue 5924 fix compare button #5929

techknowlogick added a commit that referenced this pull request Feb 4, 2019

@zeripath @techknowlogick
Issue 5924 fix compare button (#5929) 
* Revert #5877

This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Change permission check to create pull requests to CanReadIssuesOrPulls

Signed-off-by: Andrew Thornton <art27@cantab.net>
Loading status checks…
24a36e8

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 16, 2019

@zeripath
Issue 5924 fix compare button (go-gitea#5929) 
* Revert go-gitea#5877

This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Change permission check to create pull requests to CanReadIssuesOrPulls

Signed-off-by: Andrew Thornton <art27@cantab.net>
Verified
This commit was signed with a verified signature.
@zeripath zeripath
GPG key ID: 3CDE74631F13A748 Learn about signing commits
df00089

@zeripath zeripath referenced this pull request Feb 16, 2019

Merged

Issue 5924 fix compare button (#5929) #6098

lafriks added a commit that referenced this pull request Feb 16, 2019

@zeripath @lafriks
Issue 5924 fix compare button (#5929) (#6098) 
* Revert #5877

This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Change permission check to create pull requests to CanReadIssuesOrPulls

Signed-off-by: Andrew Thornton <art27@cantab.net>
Loading status checks…
fe99c99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment