New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect value of REQUIRE_SIGNIN_VIEW #5901

Merged
merged 4 commits into from Jan 30, 2019

Conversation

6 participants
@adelowo
Copy link
Member

adelowo commented Jan 30, 2019

Fixes #5899

adelowo added some commits Jan 30, 2019

@zeripath
Copy link
Contributor

zeripath left a comment

Good catch.

Is there an obvious test we can add?

I wonder if we can do some rationalisation of the :username/:repo routes. It might help prevent future situations like this if it was more explicit in the routes what had to be protected.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #5901 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5901   +/-   ##
=======================================
  Coverage   38.01%   38.01%           
=======================================
  Files         328      328           
  Lines       48337    48337           
=======================================
  Hits        18373    18373           
  Misses      27325    27325           
  Partials     2639     2639
Impacted Files Coverage Δ
routers/routes/routes.go 85.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fada696...a0ed05c. Read the comment docs.

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Jan 30, 2019

@zeripath in the PR for "private orgs" I added logic that caught a lot of the missing routes that should be hidden.

@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 30, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Jan 30, 2019

@techknowlogick you mean #1763 ? Should we just review and get that in instead?

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Jan 30, 2019

@zeripath yes, that's the PR. However I'm not sure it covers all cases, so we should get this PR in as well.

techknowlogick added some commits Jan 30, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 30, 2019

@techknowlogick techknowlogick merged commit 7933a95 into go-gitea:master Jan 30, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@adelowo adelowo deleted the adelowo:fix5899 branch Jan 30, 2019

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Jan 30, 2019

Please backport to release v1.7

adelowo added a commit to adelowo/gitea that referenced this pull request Jan 31, 2019

techknowlogick added a commit that referenced this pull request Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment