New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go-get URL generation #5905

Merged
merged 1 commit into from Jan 30, 2019

Conversation

5 participants
@lafriks
Copy link
Member

lafriks commented Jan 30, 2019

No description provided.

@lafriks lafriks added this to the 1.8.0 milestone Jan 30, 2019

@zeripath
Copy link
Contributor

zeripath left a comment

Can't believe this wasn't there already.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #5905 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5905      +/-   ##
==========================================
+ Coverage   37.99%   38.01%   +0.01%     
==========================================
  Files         328      328              
  Lines       48343    48343              
==========================================
+ Hits        18369    18377       +8     
+ Misses      27335    27326       -9     
- Partials     2639     2640       +1
Impacted Files Coverage Δ
modules/context/repo.go 59.57% <0%> (ø) ⬆️
modules/context/context.go 49.4% <0%> (ø) ⬆️
models/repo.go 44.45% <100%> (ø) ⬆️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a69ef...e92d32e. Read the comment docs.

@sapk

sapk approved these changes Jan 30, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 30, 2019

@zeripath zeripath merged commit 80098bd into go-gitea:master Jan 30, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Jan 30, 2019

@lafriks can you backport?

@lafriks lafriks deleted the lafriks:fix/go-get-url branch Jan 30, 2019

lafriks added a commit to lafriks/gitea that referenced this pull request Jan 30, 2019

@lafriks

This comment has been minimized.

Copy link
Member Author

lafriks commented Jan 30, 2019

@zeripath done

lafriks added a commit that referenced this pull request Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment