New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log output #5938

Merged
merged 1 commit into from Feb 2, 2019

Conversation

5 participants
@saromanov
Copy link
Contributor

saromanov commented Feb 2, 2019

Hi! Seems log output for errors should contain method name which it call. Please check my change

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 2, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Feb 2, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #5938 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5938      +/-   ##
==========================================
+ Coverage   37.96%   37.97%   +<.01%     
==========================================
  Files         329      329              
  Lines       48406    48406              
==========================================
+ Hits        18379    18383       +4     
+ Misses      27386    27381       -5     
- Partials     2641     2642       +1
Impacted Files Coverage Δ
models/branches.go 43.33% <0%> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ee544...1d47272. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 2, 2019

@zeripath zeripath merged commit 67567ef into go-gitea:master Feb 2, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@saromanov saromanov deleted the saromanov:fix-log-output branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment