New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all CommitStatus when a repo is deleted #5940

Merged
merged 2 commits into from Feb 3, 2019

Conversation

5 participants
@jolheiser
Copy link
Member

jolheiser commented Feb 3, 2019

Added the CommitStatus struct to the list of beans that get cleaned up when a repository is deleted.
Resolves #5926

Signed-off-by: jolheiser john.olheiser@gmail.com

Remove all CommitStatus when a repo is deleted
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #5940 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5940      +/-   ##
==========================================
- Coverage   38.28%   38.28%   -0.01%     
==========================================
  Files         330      330              
  Lines       48517    48518       +1     
==========================================
  Hits        18576    18576              
- Misses      27267    27268       +1     
  Partials     2674     2674
Impacted Files Coverage Δ
models/repo.go 44.42% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecefa9e...718f5fb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 3, 2019

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 3, 2019

@lunny

lunny approved these changes Feb 3, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 3, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Feb 3, 2019

make LG-TM work

@techknowlogick techknowlogick merged commit f81c6cc into go-gitea:master Feb 3, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Feb 3, 2019

@jolheiser please backport 😄 If you need anyhelp lmk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment