New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence console logger in gitea serv (#5887) #5943

Merged
merged 2 commits into from Feb 3, 2019

Conversation

4 participants
@zeripath
Copy link
Contributor

zeripath commented Feb 3, 2019

By default, if setting.NewContext() prints out any warning logs, these are printed to the stdout breaking git receive-pack etc. meaning that even if there is a warning because of a minor problem in your app.ini but gitea starts despite this - you CANNOT push or pull over SSH.

This PR disables the console logger whilst in serv.go

Backport #5887 to fix #5866

Signed-off-by: Andrew Thornton art27@cantab.net

Fix #5866: Silence console logger in gitea serv (#5887)
By default, if `setting.NewContext()` prints out any warning logs, these are printed to the stdout breaking `git receive-pack` etc. meaning that even if there is a warning because of a minor problem in your app.ini but gitea starts despite this - you **CANNOT** push or pull over SSH.

This PR disables the console logger whilst in `serv.go`

Signed-off-by: Andrew Thornton <art27@cantab.net>

@zeripath zeripath added this to the 1.7.2 milestone Feb 3, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Feb 3, 2019

@adelowo

adelowo approved these changes Feb 3, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 3, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Feb 3, 2019

Make LG-TM work

@techknowlogick techknowlogick merged commit 849c85a into go-gitea:release/v1.7 Feb 3, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@zeripath zeripath deleted the zeripath:backport-5887 branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment