New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Repo header tweaks #5945

Merged
merged 7 commits into from Feb 5, 2019

Conversation

7 participants
@silverwind
Copy link
Contributor

silverwind commented Feb 3, 2019

  • Use basic buttons on the header buttons, matching gogs
  • Make 'Manage topic' text smaller, remove margin-left with no topics
    present
  • Move various inline styles to CSS
  • Use flexbox on header title and buttons

Before

screenshot 2019-02-03 at 17 55 27

After

screenshot 2019-02-03 at 20 11 01

Note: The missing icon on the watch button is not related to this commit, some kind of font cache issue on my side.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@c20034b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5945   +/-   ##
========================================
  Coverage          ?   38.7%           
========================================
  Files             ?     330           
  Lines             ?   48642           
  Branches          ?       0           
========================================
  Hits              ?   18825           
  Misses            ?   27090           
  Partials          ?    2727

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20034b...9a7f322. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 3, 2019

UI: Repo header tweaks
- Use basic buttons on the header buttons, matching gogs
- Make 'Manage topic' text smaller, remove margin-left with no topics
present
- Move various inline styles to CSS
- Use flexbox on header title and buttons

@silverwind silverwind force-pushed the silverwind:ui-tweaks branch from 7faca82 to 4161da7 Feb 3, 2019

@media only screen and (max-width: 768px) {
width: 100%;
}
@media only screen and (max-width: 768px) {

This comment has been minimized.

@adelowo

adelowo Feb 3, 2019

Member

This formatting looks a little off

This comment has been minimized.

@silverwind

silverwind Feb 3, 2019

Author Contributor

It isn't really off, just made it consistent to 4-space indent. But now that I look at it, I'm not sure this will even work, you usually wrap selectors inside a media query, not the other way around, fixing that.

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 3, 2019

@silverwind

This comment has been minimized.

Copy link
Contributor Author

silverwind commented Feb 3, 2019

After screenshot updated, now centered .repo-title vertically.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 5, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 5, 2019

lafriks and others added some commits Feb 5, 2019

@techknowlogick techknowlogick merged commit acaf5c9 into go-gitea:master Feb 5, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@jolheiser jolheiser referenced this pull request Feb 6, 2019

Closed

Repo header formatting issue #5985

1 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment