New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle milestone events for issues and PR #5947

Merged
merged 2 commits into from Feb 3, 2019

Conversation

@adelowo
Copy link
Member

adelowo commented Feb 3, 2019

Fixes #5865

adelowo added some commits Feb 2, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Feb 3, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Feb 3, 2019

Looks good. Can you add them to the other hook types too?

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #5947 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5947      +/-   ##
==========================================
- Coverage   38.54%   38.54%   -0.01%     
==========================================
  Files         330      330              
  Lines       48518    48526       +8     
==========================================
+ Hits        18700    18703       +3     
- Misses      27111    27117       +6     
+ Partials     2707     2706       -1
Impacted Files Coverage Δ
models/webhook_slack.go 0% <0%> (ø) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c0f7d...7268fcd. Read the comment docs.

@adelowo

This comment has been minimized.

Copy link
Member Author

adelowo commented Feb 3, 2019

@techknowlogick All other webhooks already support this

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 3, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Feb 3, 2019

@adelowo thanks :)

@techknowlogick techknowlogick merged commit 746cf22 into go-gitea:master Feb 3, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@adelowo adelowo deleted the adelowo:fix_5865 branch Feb 3, 2019

@lunny lunny added the backport/v1.7 label Feb 4, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Feb 4, 2019

@adelowo I think this should be back port to release/v1.7

adelowo added a commit to adelowo/gitea that referenced this pull request Feb 4, 2019

zeripath added a commit that referenced this pull request Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment