Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show user who created the repository instead of the organisation in action feed #5948

Merged
merged 1 commit into from Feb 3, 2019

Conversation

@adelowo
Copy link
Member

commented Feb 3, 2019

Fixes #2431

@codecov-io

This comment has been minimized.

Copy link

commented Feb 3, 2019

Codecov Report

Merging #5948 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5948      +/-   ##
==========================================
+ Coverage   38.54%   38.54%   +<.01%     
==========================================
  Files         330      330              
  Lines       48526    48526              
==========================================
+ Hits        18702    18705       +3     
+ Misses      27116    27113       -3     
  Partials     2708     2708
Impacted Files Coverage Δ
models/repo.go 47.46% <0%> (ø) ⬆️
models/repo_watch.go 68.6% <0%> (+3.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 746cf22...b85aa56. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 3, 2019

@zeripath
Copy link
Contributor

left a comment

I think leaving the u in the comment is better, but I can see it should be unnecessary.

What would actually be better is a description of what doer is compared to u. I'm struggling to think of something succinct & pithy though.

Perhaps: CreateRepository creates a repository as doer for the provided user/organization u

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 3, 2019

@lafriks

lafriks approved these changes Feb 3, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 3, 2019

@lafriks lafriks merged commit 634cbaa into go-gitea:master Feb 3, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks added this to the 1.8.0 milestone Feb 3, 2019

@adelowo adelowo deleted the adelowo:fix_2431 branch Feb 3, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@adelowo please send a back port to release/v1.7

@lunny lunny added the backport/v1.7 label Feb 4, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@lafriks I think this should be a bug rather than an enhancement.

@lafriks lafriks added kind/bug and removed kind/enhancement labels Feb 4, 2019

adelowo added a commit to adelowo/gitea that referenced this pull request Feb 4, 2019

lafriks added a commit that referenced this pull request Feb 4, 2019

Mikescher added a commit to Mikescher/gitea that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.