New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add other session providers #5963

Merged
merged 6 commits into from Feb 5, 2019

Conversation

5 participants
@techknowlogick
Copy link
Member

techknowlogick commented Feb 4, 2019

Fix #3717

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 4, 2019

techknowlogick added some commits Feb 4, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #5963 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5963      +/-   ##
=========================================
- Coverage    38.7%   38.7%   -0.01%     
=========================================
  Files         330     330              
  Lines       48642   48642              
=========================================
- Hits        18827   18825       -2     
- Misses      27088   27090       +2     
  Partials     2727    2727
Impacted Files Coverage Δ
modules/setting/setting.go 51.71% <100%> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4bada...271c4c3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 4, 2019

@lafriks

lafriks approved these changes Feb 5, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 5, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 5, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member Author

techknowlogick commented Feb 5, 2019

make LG-TM work

@techknowlogick techknowlogick merged commit 9de871a into go-gitea:master Feb 5, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@techknowlogick techknowlogick deleted the techknowlogick:issue-3717 branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment