New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose issue stopwatch toggling via API #5970

Merged
merged 8 commits into from Feb 7, 2019

Conversation

5 participants
@adelowo
Copy link
Member

adelowo commented Feb 5, 2019

.. #4327 automatically stops the stopwatch but this PR will be useful in case there
is a need to programmatically toggle the stopwatch.

Fixes #5942

@adelowo adelowo force-pushed the adelowo:expose_time_tracking_as_api branch from 4fc3634 to 488c40c Feb 5, 2019

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 5, 2019

@adelowo adelowo changed the title Expose issue stopwatch in API Expose issue stopwatch toggling via API Feb 5, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #5970 into master will decrease coverage by 0.09%.
The diff coverage is 3.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5970     +/-   ##
=========================================
- Coverage    38.8%   38.71%   -0.1%     
=========================================
  Files         330      330             
  Lines       48731    48853    +122     
=========================================
+ Hits        18911    18912      +1     
- Misses      27081    27201    +120     
- Partials     2739     2740      +1
Impacted Files Coverage Δ
routers/api/v1/repo/issue.go 23.46% <0%> (-7.81%) ⬇️
routers/api/v1/api.go 73.74% <100%> (+0.2%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc48c12...f10ff72. Read the comment docs.

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 5, 2019

@lafriks
Copy link
Member

lafriks left a comment

I don't actually like toggle method as you are kind of guessing state... I would prefer if API had start & stop methods

adelowo added some commits Feb 5, 2019

@adelowo adelowo force-pushed the adelowo:expose_time_tracking_as_api branch from 488c40c to 2f9fb24 Feb 5, 2019

@adelowo

This comment has been minimized.

Copy link
Member Author

adelowo commented Feb 5, 2019

Done @lafriks.

adelowo added some commits Feb 5, 2019

Show resolved Hide resolved routers/api/v1/repo/issue.go Outdated
Show resolved Hide resolved routers/api/v1/repo/issue.go
@lafriks

lafriks approved these changes Feb 6, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 6, 2019

@lafriks lafriks added the kind/feature label Feb 6, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 7, 2019

techknowlogick added some commits Feb 7, 2019

@techknowlogick techknowlogick merged commit 9dfdf80 into go-gitea:master Feb 7, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@adelowo adelowo deleted the adelowo:expose_time_tracking_as_api branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment