New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines #5976

Merged
merged 3 commits into from Feb 7, 2019

Conversation

@lunny
Copy link
Member

lunny commented Feb 6, 2019

No description provided.

@lunny lunny added this to the 1.8.0 milestone Feb 6, 2019

@Nubston

Nubston approved these changes Feb 6, 2019

Copy link

Nubston left a comment

i don't quite know what lunny meant by making PR to remove dependent on ssh-keygen but i need this fix here that they have done to use the internal ssh server since i get ssh-keygen error on 1.7.1 when trying to use internal server

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 6, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #5976 into master will increase coverage by <.01%.
The diff coverage is 44.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5976      +/-   ##
=========================================
+ Coverage    38.7%   38.7%   +<.01%     
=========================================
  Files         330     330              
  Lines       48857   48884      +27     
=========================================
+ Hits        18910   18922      +12     
- Misses      27207   27217      +10     
- Partials     2740    2745       +5
Impacted Files Coverage Δ
modules/ssh/ssh.go 55.48% <44.82%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a1739...9fd05a8. Read the comment docs.

lunny added some commits Feb 6, 2019

use native golang SSH library but ssh-keygen when enable built-in SSH…
… server to remove dependent on that command lines

@lunny lunny force-pushed the lunny:lunny/gen_key branch from dd4d7f6 to 079c2c5 Feb 7, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 7, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 7, 2019

@lafriks

lafriks approved these changes Feb 7, 2019

@techknowlogick techknowlogick merged commit 2d213b6 into go-gitea:master Feb 7, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lunny lunny deleted the lunny:lunny/gen_key branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment