New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support n as a line highlight prefix #5987

Merged
merged 1 commit into from Feb 7, 2019

Conversation

5 participants
@emonty
Copy link
Contributor

emonty commented Feb 7, 2019

We're working on rolling out gitea as a replacement for a fairly
large cgit installation. Part of this involves a metric ton of
mod_rewrite rules so that links people have out in the wild will
still work. Unfortunately, cgit uses #n1 in the url to indicate
a single line highlight, which doesn't get passed to the server
and therefore can't be rewritten.

We've got a local workaround by shoving a script block into a
custom header template, but thought it might be nicer to upstream
a simple patch to support #n as a prefix for single line highlights.
(luckily for simplicity, cgit does not support ranges)

Signed-off-by: Monty Taylor mordred@inaugust.com

Support n as a line highlight prefix
We're working on rolling out gitea as a replacement for a fairly
large cgit installation. Part of this involves a metric ton of
mod_rewrite rules so that links people have out in the wild will
still work. Unfortunately, cgit uses #n1 in the url to indicate
a single line highlight, which doesn't get passed to the server
and therefore can't be rewritten.

We've got a local workaround by shoving a script block into a
custom header template, but thought it might be nicer to upstream
a simple patch to support #n as a prefix for single line highlights.
(luckily for simplicity, cgit does not support ranges)

Signed-off-by: Monty Taylor <mordred@inaugust.com>
@emonty

This comment has been minimized.

Copy link
Contributor Author

emonty commented Feb 7, 2019

Incidentally, if landing this upstream isn't cool, no worries.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 7, 2019

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 7, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #5987 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5987   +/-   ##
=======================================
  Coverage   38.79%   38.79%           
=======================================
  Files         330      330           
  Lines       48729    48729           
=======================================
  Hits        18904    18904           
- Misses      27085    27086    +1     
+ Partials     2740     2739    -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1edbf...a69abdd. Read the comment docs.

@lafriks

lafriks approved these changes Feb 7, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 7, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 7, 2019

@techknowlogick techknowlogick merged commit 44d6a90 into go-gitea:master Feb 7, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Feb 7, 2019

Thanks for PR @emonty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment