New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix header menu misalignment #6002

Merged
merged 2 commits into from Feb 8, 2019

Conversation

8 participants
@silverwind
Copy link
Contributor

silverwind commented Feb 8, 2019

The icons in the '+' menu were misaligned, fixed it by using the same icon classes as on the user menu.

Before

screenshot 2019-02-08 at 08 33 34

After

screenshot 2019-02-08 at 08 33 22

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Feb 8, 2019

I assume this doesn't degrade the mobile view. I'm surprised the fitted was put there.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 8, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 8, 2019

@silverwind

This comment has been minimized.

Copy link
Contributor Author

silverwind commented Feb 8, 2019

Mobile view looks fine:

screenshot 2019-02-08 at 11 18 43

@lafriks lafriks added the kind/ui label Feb 8, 2019

@lafriks lafriks added this to the 1.8.0 milestone Feb 8, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Feb 8, 2019

CI failed.

@adelowo

This comment has been minimized.

Copy link
Member

adelowo commented Feb 8, 2019

Failure seems unrelated to this PR

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 8, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 8, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@db58dba). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6002   +/-   ##
=========================================
  Coverage          ?   38.72%           
=========================================
  Files             ?      332           
  Lines             ?    48992           
  Branches          ?        0           
=========================================
  Hits              ?    18973           
  Misses            ?    27272           
  Partials          ?     2747

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db58dba...3cfcf82. Read the comment docs.

@techknowlogick techknowlogick merged commit c3d8fb7 into go-gitea:master Feb 8, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment