Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default create repository on organisation on its dashboard #6026

Merged
merged 3 commits into from Feb 10, 2019

Conversation

@zeripath
Copy link
Contributor

commented Feb 9, 2019

When in an organisation's context on the dashboard the create repository "+" button causes default creation on the logged in user. This PR changes this to default to creating on the contexted organisation and will only show the add new repository button if you can create a repository in that organisation.

Fix #3253

zeripath added some commits Feb 9, 2019

Default create repository on organisation on its dashboard
Fix #3253

Signed-off-by: Andrew Thornton <art27@cantab.net>
Only allow owners to add new repositories to an organisation
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2019

There is a current issue with the repository search - in that it gives completely different results to that obtained by the organisation profile. This needs to be fixed and can either be done as part of this PR or as another PR.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 9, 2019

Codecov Report

Merging #6026 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6026      +/-   ##
==========================================
- Coverage   38.73%   38.72%   -0.02%     
==========================================
  Files         338      338              
  Lines       48994    48994              
==========================================
- Hits        18977    18971       -6     
- Misses      27269    27276       +7     
+ Partials     2748     2747       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 46.1% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820e28c...31750f3. Read the comment docs.

@zeripath zeripath added this to the 1.8.0 milestone Feb 9, 2019

@lunny

lunny approved these changes Feb 10, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 10, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 10, 2019

@zeripath zeripath merged commit c0adb5e into go-gitea:master Feb 10, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@zeripath zeripath deleted the zeripath:issue-3253-default-to-organisation branch Feb 10, 2019

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 12, 2019

Create repository on organisation by default on its dashboard (go-git…
…ea#6026)

* Create repository on organisation by default on its dashboard
* Only show owners the add new repositories to an organisation button.

Fix go-gitea#3253

Signed-off-by: Andrew Thornton <art27@cantab.net>

techknowlogick added a commit that referenced this pull request Feb 13, 2019

Create repository on organisation by default on its dashboard (#6026) (
…#6048)

* Create repository on organisation by default on its dashboard
* Only show owners the add new repositories to an organisation button.

Fix #3253

Signed-off-by: Andrew Thornton <art27@cantab.net>

Mikescher added a commit to Mikescher/gitea that referenced this pull request Mar 20, 2019

Create repository on organisation by default on its dashboard (go-git…
…ea#6026)

* Create repository on organisation by default on its dashboard
* Only show owners the add new repositories to an organisation button.

Fix go-gitea#3253

Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.