Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: make sure labels are actually returned #6053

Merged
merged 3 commits into from Feb 13, 2019

Conversation

@adelowo
Copy link
Member

commented Feb 13, 2019

This fixes an item in #6047 .

I couldn't replicate the other 401 the poster talked about

adelowo added some commits Feb 13, 2019

@adelowo adelowo referenced this pull request Feb 13, 2019
2 of 6 tasks complete
@codecov-io

This comment has been minimized.

Copy link

commented Feb 13, 2019

Codecov Report

Merging #6053 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6053      +/-   ##
==========================================
- Coverage   38.87%   38.86%   -0.01%     
==========================================
  Files         345      345              
  Lines       49503    49507       +4     
==========================================
- Hits        19243    19241       -2     
- Misses      27477    27483       +6     
  Partials     2783     2783
Impacted Files Coverage Δ
routers/api/v1/repo/issue_label.go 29.52% <0%> (-0.45%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23414ac...9f543b8. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 13, 2019

@lafriks lafriks added the kind/bug label Feb 13, 2019

@lafriks lafriks added this to the 1.8.0 milestone Feb 13, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

I don't think there's a test covering this API, although I understand you can't quite reproduce the issue - it would be good if there was at least a test.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 13, 2019

@techknowlogick techknowlogick merged commit f2256d9 into go-gitea:master Feb 13, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@adelowo adelowo deleted the adelowo:fix_label_api branch Feb 13, 2019

adelowo added a commit to adelowo/gitea that referenced this pull request Feb 13, 2019

zeripath added a commit that referenced this pull request Feb 13, 2019

Mikescher added a commit to Mikescher/gitea that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.