Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In basic auth check for tokens before call UserSignIn (#5725) #6083

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@lafriks
Copy link
Member

commented Feb 15, 2019

Backport #5725

In basic auth check for tokens before call UserSignIn (#5725)
* Check first if user/password is a token

* In basic auth check if user/password is a token

* Remove unnecessary else statement

* Changes of fmt

@lafriks lafriks added the kind/bug label Feb 15, 2019

@lafriks lafriks added this to the 1.7.2 milestone Feb 15, 2019

@techknowlogick techknowlogick modified the milestones: 1.7.2, 1.7.3 Feb 15, 2019

@lafriks lafriks referenced this pull request Feb 15, 2019
@lafriks

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

@techknowlogick really need this one to get out asap... drone is unusable with AD server with user locking on unsuccessful auths as on every build it blocks users :(

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@lafriks ok, as we haven’t published blog post yet I think we can get this one in to 1.7.2

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 15, 2019

@lafriks lafriks modified the milestones: 1.7.3, 1.7.2 Feb 15, 2019

@lafriks lafriks merged commit 1d8e56e into go-gitea:release/v1.7 Feb 15, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks deleted the lafriks-fork:backport/fix/token-auth branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.