Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock in webhook PullRequest (#6102) #6104

Merged
merged 1 commit into from Feb 18, 2019

Conversation

@zeripath
Copy link
Contributor

commented Feb 17, 2019

Backport #6102

The webhooks currently use a call to MakeAssigneeList to get the assignees of an issue - however, this causes an SQL deadlock due to use of models.x whilst in a transaction. This call is unnecessary as the assignees are actually provided in the api.PullRequest.

Fix #6088

Signed-off-by: Andrew Thornton art27@cantab.net

Fix deadlock in webhook PullRequest (#6102)
Signed-off-by: Andrew Thornton <art27@cantab.net>

@zeripath zeripath added this to the 1.7.3 milestone Feb 17, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

Ceterum autem censeo x exempla monstrabit esse delendam.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 18, 2019

@lunny

lunny approved these changes Feb 18, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 18, 2019

@techknowlogick techknowlogick merged commit 5cca840 into go-gitea:release/v1.7 Feb 18, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks removed the backport/v1.7 label Feb 18, 2019

@zeripath zeripath deleted the zeripath:backport-6102 branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.