Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ldap.v3 to fix #5928 #6105

Merged
merged 2 commits into from Feb 18, 2019

Conversation

@zeripath
Copy link
Contributor

commented Feb 17, 2019

As suggested in #5928 - this PR moves to ldap.v3 in an attempt to fix the regressions seen in LDAP.

I don't have a decent test case for this so I'm only working off what has been suggested.

Signed-off-by: Andrew Thornton art27@cantab.net

Move to ldap.v3 to fix #5928
Signed-off-by: Andrew Thornton <art27@cantab.net>

@zeripath zeripath added this to the 1.8.0 milestone Feb 17, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 17, 2019

Codecov Report

Merging #6105 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6105      +/-   ##
==========================================
+ Coverage   38.85%   38.86%   +<.01%     
==========================================
  Files         345      345              
  Lines       49510    49510              
==========================================
+ Hits        19237    19241       +4     
+ Misses      27491    27486       -5     
- Partials     2782     2783       +1
Impacted Files Coverage Δ
modules/auth/ldap/ldap.go 54.4% <ø> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 46.22% <0%> (+1.16%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a380cfd...036e41e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 18, 2019

@lunny

lunny approved these changes Feb 18, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 18, 2019

@zeripath zeripath merged commit 22770c3 into go-gitea:master Feb 18, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@zeripath zeripath deleted the zeripath:issues-5928-move-to-ldap.v3 branch Feb 18, 2019

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 18, 2019

Move to ldap.v3 to fix go-gitea#5928 (go-gitea#6105)
Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added a commit that referenced this pull request Feb 18, 2019

Move to ldap.v3 to fix #5928 (#6105) (#6107)
Signed-off-by: Andrew Thornton <art27@cantab.net>

@zeripath zeripath referenced this pull request Feb 27, 2019

Merged

Add Changelog for 1.7.3 #6202

Mikescher added a commit to Mikescher/gitea that referenced this pull request Mar 20, 2019

Move to ldap.v3 to fix go-gitea#5928 (go-gitea#6105)
Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.