Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prohibit login check on authorization (#6106) #6115

Merged
merged 2 commits into from Feb 19, 2019

Conversation

@lunny
Copy link
Member

commented Feb 19, 2019

back port from #6106

  • fix bug prohibit login not applied on dashboard
  • fix tests
  • fix bug user status leak
  • fix typo
  • return after render
Fix prohibit login check on authorization (#6106)
* fix bug prohibit login not applied on dashboard

* fix tests

* fix bug user status leak

* fix typo

* return after render

@lunny lunny added the kind/bug label Feb 19, 2019

@lunny lunny added this to the 1.7.3 milestone Feb 19, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 19, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

CI Fail

@lafriks

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

make lg-tm work

@lafriks lafriks merged commit 597a30b into go-gitea:release/v1.7 Feb 19, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lunny lunny deleted the lunny:lunny/fix_bug_prohibit_login2 branch Feb 19, 2019

@lunny lunny referenced this pull request Feb 23, 2019

Closed

Deactivated administrators are not deactivated? #6151

1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.