Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates vendor/code.gitea.io/git #6286

Merged
merged 3 commits into from Mar 11, 2019

Conversation

7 participants
@richmahn
Copy link
Contributor

richmahn commented Mar 8, 2019

Updates the dep for code.gitea.io/git

@techknowlogick techknowlogick added this to the 1.8.0 milestone Mar 8, 2019

@techknowlogick techknowlogick requested a review from lunny Mar 8, 2019

@richmahn

This comment has been minimized.

Copy link
Contributor Author

richmahn commented Mar 10, 2019

@lunny Pending your review on how we should handle getting my changes to the git repo when you have changes in there for v1.9.

@richmahn

This comment has been minimized.

Copy link
Contributor Author

richmahn commented Mar 10, 2019

@techknowlogick @lunny I also see the build fails due to there needing to be a change to a call to what lunny did for the cache in the gitea code.

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Mar 10, 2019

Given the caching code seems to be able to cope with nil for the cache it's probably quickest to just change the broken bits in Gitea to pass in nil

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Mar 11, 2019

I think this has been replaced by #6224

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Mar 11, 2019

Actually Rich if you update this so that you use the latest git master you can fix #6292.

richmahn added some commits Mar 11, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #6286 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6286   +/-   ##
=======================================
  Coverage   38.83%   38.83%           
=======================================
  Files         359      359           
  Lines       51100    51100           
=======================================
  Hits        19844    19844           
  Misses      28384    28384           
  Partials     2872     2872

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c20560...2f4e417. Read the comment docs.

@GiteaBot GiteaBot removed the lgtm/need 2 label Mar 11, 2019

@lafriks lafriks added the lgtm/need 2 label Mar 11, 2019

@lafriks lafriks removed the kind/build label Mar 11, 2019

@techknowlogick techknowlogick merged commit 50631b5 into go-gitea:master Mar 11, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.