Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add golangci #6418
referenced this pull request
Mar 24, 2019
Fixed most of the issues, however there are some issues where I don't really know what to do:
It looks like
I don't know how it is possible to let
I don't really think this is an issue... or is it?
If the errors are not checked, can the whole check be removed? Or how can we check for the error?
@lunny It's just a binary file which runs locally and in drone. Since we run it on our own infrastructure, we're not tied to a particular platform.
IIRC they offer tight ingration with github (things like having a bot which comments on the pr instead of just failing the pipeline) which we won't have. But I see no problem with it just failing the pipeline.
sapk left a comment
That a lot of missed error checking and more could still be logged in goroutine or defer. This will really improve the codebase and review.