Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload attachments #6481

Merged
merged 5 commits into from Apr 2, 2019

Conversation

6 participants
@lunny
Copy link
Member

commented Apr 1, 2019

Should fix #4721

@lunny lunny added the kind/bug label Apr 1, 2019

@lunny lunny added this to the 1.9.0 milestone Apr 1, 2019

@lafriks

lafriks approved these changes Apr 1, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Apr 1, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 1, 2019

@lafriks
Copy link
Member

left a comment

Please add new migration to call sync2 on attachmet table with new field

@codecov-io

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #6481 into master will increase coverage by <.01%.
The diff coverage is 17.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
+ Coverage   40.18%   40.18%   +<.01%     
==========================================
  Files         402      403       +1     
  Lines       54021    54037      +16     
==========================================
+ Hits        21707    21717      +10     
+ Misses      29307    29306       -1     
- Partials     3007     3014       +7
Impacted Files Coverage Δ
models/migrations/migrations.go 1.52% <ø> (ø) ⬆️
routers/api/v1/repo/release_attachment.go 0% <0%> (ø) ⬆️
models/migrations/v83.go 0% <0%> (ø)
routers/repo/attachment.go 12.24% <0%> (-0.8%) ⬇️
routers/routes/routes.go 81.84% <100%> (+0.04%) ⬆️
models/attachment.go 52.05% <100%> (+8.43%) ⬆️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8e63c...4043757. Read the comment docs.

@lunny

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

@lafriks done.

lunny added some commits Apr 1, 2019

@lafriks

lafriks approved these changes Apr 2, 2019

@techknowlogick techknowlogick merged commit 09fb036 into go-gitea:master Apr 2, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_upload_attachement branch Apr 3, 2019

@chotaire

This comment has been minimized.

Copy link

commented Apr 7, 2019

Tested as working in Gitea Version: 1.9.0+dev-61-g7ed65a98e. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.