Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifies pagination template usage (#6531) #6533

Merged
merged 10 commits into from Apr 20, 2019

Conversation

7 participants
@saitho
Copy link
Contributor

commented Apr 7, 2019

This pull request makes the additional URL params that are used in the pagination template configurable. This enables the usage of the same template among all pages that use a pagination.

Resolves #6531.


How to test

Check the paginations on all pages that use one, i.e. templates with {{template "base/paginate" .}}

@saitho saitho changed the title Unifies pagination template usage (#6531) [WIP] Unifies pagination template usage (#6531) Apr 7, 2019

Show resolved Hide resolved routers/admin/notice.go
Show resolved Hide resolved modules/context/pagination.go Outdated
Show resolved Hide resolved modules/context/pagination.go Outdated

saitho added some commits Apr 7, 2019

Unifies pagination template usage (#6531)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Introduce extended paginater component (#6531)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

@saitho saitho force-pushed the saitho:feature/unify_pagination branch from 218c9f9 to 0a5195e Apr 13, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 13, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@40dc458). Click here to learn what that means.
The diff coverage is 69.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6533   +/-   ##
=========================================
  Coverage          ?   40.83%           
=========================================
  Files             ?      419           
  Lines             ?    57340           
  Branches          ?        0           
=========================================
  Hits              ?    23413           
  Misses            ?    30804           
  Partials          ?     3123
Impacted Files Coverage Δ
routers/repo/view.go 41.6% <0%> (ø)
routers/admin/notice.go 0% <0%> (ø)
routers/repo/milestone.go 0% <0%> (ø)
routers/repo/issue.go 37.09% <100%> (ø)
modules/context/pagination.go 100% <100%> (ø)
routers/repo/search.go 60.71% <100%> (ø)
routers/user/notification.go 48.27% <100%> (ø)
routers/repo/release.go 33.9% <100%> (ø)
modules/context/api.go 49% <22.22%> (ø)
routers/repo/commit.go 25% <50%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40dc458...94a3a83. Read the comment docs.

@saitho saitho changed the title [WIP] Unifies pagination template usage (#6531) Unifies pagination template usage (#6531) Apr 13, 2019

@saitho saitho marked this pull request as ready for review Apr 13, 2019

Show resolved Hide resolved modules/context/pagination.go Outdated

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 16, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

There's a Conflict with a commit in master.

Otherwise this now looks good

Show resolved Hide resolved modules/context/pagination.go Outdated

@saitho saitho force-pushed the saitho:feature/unify_pagination branch from 7cccc57 to 3184884 Apr 17, 2019

Show resolved Hide resolved modules/context/pagination.go Outdated
Update modules/context/pagination.go
Co-Authored-By: saitho <mario.lubenka@googlemail.com>

@lafriks lafriks added this to the 1.9.0 milestone Apr 18, 2019

saitho added some commits Apr 19, 2019

Fix string casting in pagination.go (#6531)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Store urlParams as array of strings instead of template.URL (#6531)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Merge remote-tracking branch 'origin/master' into feature/unify_pagin…
…ation

# Conflicts:
#	routers/repo/commit.go

@techknowlogick techknowlogick requested a review from lunny Apr 19, 2019

@lunny

lunny approved these changes Apr 20, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 20, 2019

@techknowlogick techknowlogick merged commit fcbac38 into go-gitea:master Apr 20, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.