Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CSS cleanup for the navbar #6553

Merged
merged 4 commits into from Apr 11, 2019

Conversation

@silverwind
Copy link
Contributor

commented Apr 9, 2019

Few minor tweaks related to the navbar:

  • Add !important to navbar wrapper's margin to eliminate a small gap visible in the navbar border on top-right caused by semantic-ui margins.
  • Add a min-height to the logo to prevent navbar changing height while the image is still loading.
  • Remove some vendor-prefixed already handled by autoprefixer.
  • Remove two rather obvious comments.
@codecov-io

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #6553 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6553      +/-   ##
==========================================
- Coverage   40.37%   40.36%   -0.02%     
==========================================
  Files         405      405              
  Lines       54260    54260              
==========================================
- Hits        21907    21901       -6     
- Misses      29337    29344       +7     
+ Partials     3016     3015       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02c6a1...7356eee. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Apr 9, 2019

@lafriks

lafriks approved these changes Apr 9, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 9, 2019

@silverwind

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

Small fix pushed to navbar height. Now the min-height is set on the navbar itself rather than the logo which should allow users to use logos less than 30px high.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 10, 2019

@lunny lunny added the kind/ui label Apr 11, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@silverwind any screenshot?

@silverwind

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Not much to show, but here you go:

remove extra padding on the right side of the navbar:

before

image

after

image

make navbar fixed height when logo is absent/not loaded yet:

before

image

after

image

@sapk

sapk approved these changes Apr 11, 2019

@zeripath zeripath merged commit dc52868 into go-gitea:master Apr 11, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny added this to the 1.9.0 milestone Apr 12, 2019

@lunny lunny referenced this pull request Apr 27, 2019

Closed

a problem with the navigation bar style #6776

2 of 7 tasks complete

silverwind added a commit to silverwind/gitea that referenced this pull request Apr 27, 2019

Minor CSS cleanup for the navbar (go-gitea#6553)
* Minor CSS cleanup for the navbar
* move height fix to navbar

silverwind added a commit to silverwind/gitea that referenced this pull request Apr 27, 2019

Minor CSS cleanup for the navbar (go-gitea#6553)
* Minor CSS cleanup for the navbar
* move height fix to navbar

Fixes: go-gitea#6776

techknowlogick added a commit that referenced this pull request Apr 29, 2019

Minor CSS cleanup for the navbar (#6553) (#6781)
* Minor CSS cleanup for the navbar
* move height fix to navbar

Fixes: #6776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.