Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly adjust mirror url #6593

Merged
merged 2 commits into from Apr 12, 2019

Conversation

@zeripath
Copy link
Contributor

commented Apr 12, 2019

No description provided.

@kolaente
Copy link
Member

left a comment

Small nit, looks good otherwise.

routers/repo/setting.go Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@01e0408). Click here to learn what that means.
The diff coverage is 8.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6593   +/-   ##
=========================================
  Coverage          ?   40.47%           
=========================================
  Files             ?      405           
  Lines             ?    54388           
  Branches          ?        0           
=========================================
  Hits              ?    22015           
  Misses            ?    29346           
  Partials          ?     3027
Impacted Files Coverage Δ
models/repo_mirror.go 23.65% <0%> (ø)
routers/repo/setting.go 10.07% <10%> (ø)
models/repo.go 46.92% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e0408...c971b1f. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 12, 2019

@jolheiser
Copy link
Member

left a comment

Works with my local tests. 👍

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 12, 2019

@zeripath zeripath merged commit b3e757a into go-gitea:master Apr 12, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:fix-mirror branch Apr 12, 2019

zeripath added a commit to zeripath/gitea that referenced this pull request Apr 12, 2019

zeripath added a commit to zeripath/gitea that referenced this pull request Apr 12, 2019

zeripath added a commit that referenced this pull request Apr 12, 2019

techknowlogick added a commit that referenced this pull request Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.